RAD-88: Update observation descriptions #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…into RAD-88_Observation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 4 4
Lines 215 215
=======================================
Hits 206 206
Misses 9 9 ☔ View full report in Codecov by Sentry. |
PaulHuwe
requested review from
kdupriestsci,
jbrookens,
WilliamJamieson and
a team
as code owners
| destination: [WFIExposure.visit, GuideWindow.visit] | ||
| visit_file_group: | ||
| title: Visit File Group | ||
| description: | | ||
| The visit file group identifies the sequence group | ||
| within the visit file. The allowed range of visit file group | ||
| numbers is 01 to 99 inclusive. | ||
| type: string | ||
| type: integer | ||
| maxLength: 3 |
There was a problem hiding this comment.
don't need maxLength if it's an integer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RAD-88
Closes #187
This PR updates observation descriptions
Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change