-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roman dev - WIP #296
Roman dev - WIP #296
Conversation
Hey @Witchblade101 thank you for submitting this! I can review it and let you know what I think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I say we revisit this once the code for Roman matures a little bit, but being able to generate the apertures is a great first step. Thanks @Witchblade101!
@Witchblade101 is this PR still a WIP? Besides displaying the apertures, have there been any more coding updates or changes @tddesjardins? |
@mfixstsci no further updates here. All the existing tools for transformations in pysiaf work for us, and we don't currently plan to include the SIAF generation code in this repo (at least, not yet?). |
Hi folks! In jdaviz we now support instrument footprint overlays on images in Imviz (spacetelescope/jdaviz#2341) via Is there a timeline for merge for the Roman features in this PR? Thanks! |
Re-pinging @mfixstsci and @Witchblade101 to see if we can close the loop on this soon. |
My quick-and-dirty attempt at adding the Roman SIAF to PySIAF from February. This definitely still needs some cleaning up, the tests added, and documentation, but I wanted to make sure Mees and Tyler have a chance to look at it.