Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin components from template_mixin.py to components.py #79

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 3, 2024

Even though we use a giant template_mixin.py file in jdaviz, these plugin re-usable components make more sense to be with their vue files and called components.

This should be rebased on main once #77 is merged.

@kecnry kecnry force-pushed the template-mixin-no-more branch from 662cb4a to 33d8262 Compare January 10, 2024 13:04
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a4eaea7) 95.04% compared to head (33d8262) 94.47%.
Report is 3 commits behind head on main.

❗ Current head 33d8262 differs from pull request most recent head 38fd81f. Consider uploading reports for the commit 38fd81f to get more accurate results

Files Patch % Lines
lcviz/components/components.py 92.30% 5 Missing ⚠️
lcviz/plugins/flatten/flatten.py 81.48% 5 Missing ⚠️
lcviz/tools.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   95.04%   94.47%   -0.57%     
==========================================
  Files          32       35       +3     
  Lines        1393     1539     +146     
==========================================
+ Hits         1324     1454     +130     
- Misses         69       85      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry force-pushed the template-mixin-no-more branch from 33d8262 to 38fd81f Compare January 10, 2024 13:39
@kecnry kecnry marked this pull request as ready for review January 10, 2024 13:48
@kecnry kecnry merged commit f8f4e41 into spacetelescope:main Jan 10, 2024
9 checks passed
@kecnry kecnry deleted the template-mixin-no-more branch January 10, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant