Fixing density map toggle for short cadence data for HAT-P-7 notebook #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kecnry/lcviz-demos#2 shows an example notebook for short cadence observations. It is currently failing with jdaviz main because the light curve has 300k measurements, which triggers glue's
density_mapscatter viewer mode. We have guardrails to prevent this from happening in the time scatter viewer, but the periodogram plot in the plugin-specific frequency analysis viewer did not have thedensity_mapset to False. For reasons I don't fully understand, the density map causes a failure later on in glue-jupyter.It's possible that case could use an upstream fix in glue-jupyter. But for now, we wouldn't want a density map in the periodogram viewer anyway, so it's quite easy to make this change locally to fix our use case.