Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow #70

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Release workflow #70

merged 6 commits into from
Dec 14, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 7, 2023

This PR enables lcviz.test and adapts the release workflow used in jdaviz.

  • need to setup the secret token in the repo before first release! (switched to hopefully working with trusted publisher without the need for a token)
  • do we want changelog enforcement going forward? (That can always be added later though)

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56b2ea8) 95.03% compared to head (3d49e17) 95.04%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   95.03%   95.04%   +0.01%     
==========================================
  Files          32       32              
  Lines        1389     1393       +4     
==========================================
+ Hits         1320     1324       +4     
  Misses         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry force-pushed the release-workflow branch 2 times, most recently from 2a2f904 to 093025c Compare December 7, 2023 18:42
@kecnry kecnry marked this pull request as ready for review December 11, 2023 14:56
@kecnry kecnry requested a review from bmorris3 December 11, 2023 14:56
Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Let's do it!

@kecnry kecnry merged commit a4eaea7 into spacetelescope:main Dec 14, 2023
11 checks passed
@kecnry kecnry deleted the release-workflow branch December 14, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants