Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min lightkurve version #69

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Dec 7, 2023

This PR sets the min lightkurve version now that the upstream PR is actually released, instead of relying on referencing the latest on main directly.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9ab11d) 95.04% compared to head (9d68aa3) 95.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          32       32           
  Lines        1393     1393           
=======================================
  Hits         1324     1324           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review December 7, 2023 18:26
@kecnry kecnry requested a review from bmorris3 December 7, 2023 18:26
@kecnry kecnry merged commit 58047c5 into spacetelescope:main Dec 7, 2023
9 of 10 checks passed
@kecnry kecnry deleted the lightkurve_version branch December 7, 2023 18:38
bmorris3 pushed a commit to bmorris3/lcviz that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant