Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RR Lyrae example notebook #63

Closed
wants to merge 1 commit into from

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Nov 16, 2023

While we discuss offline about supporting too many demo notebooks like #59, I'm also opening this PR with the RR Lyrae example, just so it's logged somewhere. We can close this and #59 if we want to suggest these NBs elsewhere (jdat notebooks?) in the future.

Waiting for: jdaviz 3.8

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbdfbd4) 94.98% compared to head (d9df00e) 94.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          32       32           
  Lines        1355     1355           
=======================================
  Hits         1287     1287           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmorris3
Copy link
Contributor Author

Note: this notebook depends on the changes in spacetelescope/jdaviz#2567, which has been merged but not released.

@kecnry kecnry added the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Nov 16, 2023
@kecnry kecnry removed the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Nov 30, 2023
@bmorris3 bmorris3 marked this pull request as ready for review December 6, 2023 17:02
@bmorris3
Copy link
Contributor Author

bmorris3 commented Dec 6, 2023

Closed in favor of kecnry/lcviz-demos#3

@bmorris3 bmorris3 closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants