Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose line traitlets through plot options user API #49

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 12, 2023

This PR accompanies spacetelescope/jdaviz#2449 and exposes the now-supported line traitlets through the plot options user API.

Waiting for: jdaviz 3.8

@kecnry kecnry added the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a3c704) 95.04% compared to head (3173ae4) 95.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          32       32           
  Lines        1393     1393           
=======================================
  Hits         1324     1324           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry force-pushed the line-in-scatter-viewer branch from 3f9bc84 to 81675b2 Compare September 22, 2023 12:56
@kecnry kecnry force-pushed the line-in-scatter-viewer branch from 03a6d6d to b2210a7 Compare November 30, 2023 16:13
@kecnry kecnry marked this pull request as ready for review November 30, 2023 17:08
@kecnry kecnry removed the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Nov 30, 2023
@kecnry kecnry requested a review from bmorris3 November 30, 2023 17:08
@kecnry kecnry force-pushed the line-in-scatter-viewer branch from 9e41ba7 to 9d2788c Compare November 30, 2023 17:22
@kecnry kecnry force-pushed the line-in-scatter-viewer branch from 9d2788c to 3173ae4 Compare December 7, 2023 18:42
@kecnry kecnry merged commit 56b2ea8 into spacetelescope:main Dec 11, 2023
9 of 10 checks passed
@kecnry kecnry deleted the line-in-scatter-viewer branch December 11, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant