update to use skip_if_no_updates_since_last_active #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
9 tasks
kecnry
force-pushed
the
upstream-plugin-ping-optimization
branch
from
42129cc to
ce209d5
Compare
kecnry
added
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
upstream-plugin-ping-optimization
branch
from
d19bc69 to
aae0659
Compare
kecnry
force-pushed
the
upstream-plugin-ping-optimization
branch
from
aae0659 to
edcf4c4
Compare
kecnry
force-pushed
the
upstream-plugin-ping-optimization
branch
from
edcf4c4 to
318d6d3
Compare
kecnry
removed
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
upstream-plugin-ping-optimization
branch
from
318d6d3 to
3459a8b
Compare
kecnry
force-pushed
the
upstream-plugin-ping-optimization
branch
from
3459a8b to
95d9cee
Compare
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
kecnry
force-pushed
the
upstream-plugin-ping-optimization
branch
from
3229e02 to
6874b75
Compare
bmorris3
approved these changes
Oct 19, 2023
| 'window_length', 'polyorder', 'break_tolerance', | ||
| 'niters', 'sigma') | ||
| @skip_if_no_updates_since_last_active() |
There was a problem hiding this comment.
Unimportant: if a decorator takes no arguments, does it need to be followed by ()?
There was a problem hiding this comment.
This decorator does accept arguments, its just using the default in this case (so here it is needed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this accompanies spacetelescope/jdaviz#2386 and updates the flatten and binning plugins to make use of this new decorator, which should avoid any flickering for expensive cases.
This will require jdaviz 3.7
(once released - marking as draft until then).The binning plugin from #28 will also require updates (either as part of that PR or this rebased on top of that once merged)