Moving editable select upstream to jdaviz #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
kecnry
changed the title
Merged
kecnry
added
the
waiting-on-jdaviz-release
kecnry
force-pushed
the
upstream-editable-select
branch
from
71329bb to
12d9def
Compare
NOTE: requires changes in jdaviz and update to pin
* upstream now defaults to calling the callback before the selection is updated, with new callback names to trigger AFTER the selection is updated
kecnry
force-pushed
the
upstream-editable-select
branch
from
12d9def to
c7ac38a
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
kecnry
removed
the
waiting-on-jdaviz-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accompanies spacetelescope/jdaviz#2341 which adopts the editable select component originally introduced in #19 into jdaviz (with a few small improvements).
This would require jdaviz 3.7
(once released).