-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photometric Extraction plugin #115
Draft
kecnry
wants to merge
12
commits into
spacetelescope:main
Choose a base branch
from
kecnry:photometric-extraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
force-pushed
the
photometric-extraction
branch
from
May 29, 2024 16:58
cdd09b9
to
5f8a65e
Compare
kecnry
force-pushed
the
photometric-extraction
branch
from
June 13, 2024 07:16
c8d2496
to
b7fe196
Compare
kecnry
force-pushed
the
photometric-extraction
branch
from
June 26, 2024 15:55
b7fe196
to
e8c9be9
Compare
kecnry
force-pushed
the
photometric-extraction
branch
from
July 12, 2024 17:37
4efd5d5
to
1fc3fb5
Compare
kecnry
added
the
waiting-on-jdaviz-release
PR requires a release from jdaviz before updating the pin
label
Jul 12, 2024
kecnry
force-pushed
the
photometric-extraction
branch
from
July 12, 2024 19:28
976e6d6
to
05c4f04
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 93.92% 91.06% -2.87%
==========================================
Files 37 43 +6
Lines 1598 2104 +506
==========================================
+ Hits 1501 1916 +415
- Misses 97 188 +91 ☔ View full report in Codecov by Sentry. |
kecnry
force-pushed
the
photometric-extraction
branch
2 times, most recently
from
August 21, 2024 14:18
da6bc3e
to
a09691f
Compare
kecnry
removed
the
waiting-on-jdaviz-release
PR requires a release from jdaviz before updating the pin
label
Oct 17, 2024
kecnry
force-pushed
the
photometric-extraction
branch
from
October 17, 2024 16:36
a09691f
to
28a4cff
Compare
kecnry
force-pushed
the
photometric-extraction
branch
from
October 17, 2024 18:39
28a4cff
to
fae2324
Compare
* dropdown will still show until future PR to upstream
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress - photometric extraction from TPF data cubes.
UI is improved by spacetelescope/jdaviz#3227 but is not yet technically needed to be pinned here. Although without it, there is a warning shown in the UI about unit conflicts.
rendered plugin docs
Screen.Recording.2024-10-18.at.9.27.15.AM.mov
TODO:
Follow-up efforts:
Waiting for:
jdaviz 4.0spacetelescope/jdaviz#2939 to be merged, released, pinned