Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3750: Fix IFU cube moving target RA, Dec metadata #8911

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Oct 22, 2024

Resolves JP-3750

Closes #8796

This PR addresses incorrect RA, Dec header information for _s3d and _x1d data products for moving-target IFU data. The WCS correctly uses the MT_AVRA and MT_AVDEC as the reference point to build the cube, but the cube itself retains TARG_RA, TARG_DEC and MT_RA, MT_DEC values from the first input model instead of updating those to reflect the average of the inputs.

This also leads to a bug in the extract_1d step if the parameter ifu_autocen is set to False: the requested RA, Dec of the extraction point is outside the edge of the image as calculated by the WCS, and the code falls back to attempting extraction at the image center. This bug is not encountered often because parameter reference files set ifu_autocen=True.

This PR updates the TARG_RA, TARG_DEC and MT_RA, MT_DEC values to equal MT_AVRA, MT_AVDEC for moving-target IFU cubes, fixing the bug and making the header info more reflective of reality.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.fits_generator.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@emolter emolter added this to the Build 11.2 milestone Oct 22, 2024
@emolter
Copy link
Collaborator Author

emolter commented Oct 22, 2024

@emolter emolter requested a review from drlaw1558 October 22, 2024 22:45
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.94%. Comparing base (0938aaf) to head (576d0d9).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
jwst/cube_build/ifu_cube.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8911      +/-   ##
==========================================
+ Coverage   61.86%   61.94%   +0.08%     
==========================================
  Files         377      377              
  Lines       38881    38796      -85     
==========================================
- Hits        24052    24031      -21     
+ Misses      14829    14765      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter
Copy link
Collaborator Author

emolter commented Oct 23, 2024

First round of regression tests failed because hasattr(model.meta.wcsinfo, mt_avra) would evaluate True even if the value was None. Re-running just the failing module (test_miri_cubebuild.py) here: https://github.com/spacetelescope/RegressionTests/actions/runs/11486919742

@emolter emolter marked this pull request as ready for review October 23, 2024 14:01
@emolter emolter requested a review from a team as a code owner October 23, 2024 14:01
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending David's approval.

Copy link
Collaborator

@drlaw1558 drlaw1558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M; tested that it gives an extracted 1d spectrum that looks correct with the moving target example above, and that it doesn't affect the nominal positions in a non-moving target case.

@emolter emolter merged commit a2d6ba8 into spacetelescope:main Oct 24, 2024
30 of 31 checks passed
@emolter emolter deleted the JP-3750 branch October 24, 2024 15:20
hayescr pushed a commit to hayescr/jwst that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving target extraction coordinates not working as expected for IFU
3 participants