Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3102 follow-up: Catch source_pos nans from msa file #8874

Merged
merged 7 commits into from
Oct 24, 2024
Merged

JP-3102 follow-up: Catch source_pos nans from msa file #8874

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
687b55c
catch source pos nans from msa file
tapastro Oct 10, 2024
c4fb767
change replacement value to accommodate pps default center
tapastro Oct 10, 2024
3df0802
fragment
tapastro Oct 11, 2024
5f134d0
Merge branch 'main' into jp-3102-nan-catch
tapastro Oct 15, 2024
0c2947f
Merge branch 'main' into jp-3102-nan-catch
tapastro Oct 23, 2024
06c920d
Merge branch 'main' into jp-3102-nan-catch
tapastro Oct 24, 2024
5ee894d
Merge branch 'main' into jp-3102-nan-catch
tapastro Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions jwst/assign_wcs/nirspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,8 +674,9 @@ def get_open_msa_slits(prog_id, msa_file, msa_metadata_id, dither_position,
if n_main_shutter == 1:
# Source is marked primary
source_id = slitlet['source_id']
source_xpos = slitlet['estimated_source_in_shutter_x']
source_ypos = slitlet['estimated_source_in_shutter_y']
source_xpos = np.nan_to_num(slitlet['estimated_source_in_shutter_x'], nan=0.0)
source_ypos = np.nan_to_num(slitlet['estimated_source_in_shutter_y'], nan=0.0)

log.info(f'Found fixed slit {slitlet_id} with source_id = {source_id}.')

# Get source info for this slitlet:
Expand Down Expand Up @@ -746,8 +747,8 @@ def get_open_msa_slits(prog_id, msa_file, msa_metadata_id, dither_position,
elif n_main_shutter == 1:
xcen, ycen, quadrant, source_xpos, source_ypos = [
(s['shutter_row'], s['shutter_column'], s['shutter_quadrant'],
s['estimated_source_in_shutter_x'],
s['estimated_source_in_shutter_y'])
np.nan_to_num(s['estimated_source_in_shutter_x'], nan=0.0),
np.nan_to_num(s['estimated_source_in_shutter_y'], nan=0.0))
for s in slitlet_rows if s['background'] == 'N'][0]
shutter_id = xcen + (ycen - 1) * 365 # shutter numbers in MSA file are 1-indexed

Expand Down
Loading