Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-170] pin Python<3.13 #8703

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Aug 12, 2024

Resolves SCSB-170

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Aug 12, 2024
@github-actions github-actions bot added testing installation automation Continuous Integration (CI) and testing automation tools labels Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.38%. Comparing base (9616df3) to head (958240c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8703      +/-   ##
==========================================
+ Coverage   60.35%   60.38%   +0.02%     
==========================================
  Files         372      372              
  Lines       38360    38337      -23     
==========================================
- Hits        23151    23148       -3     
+ Misses      15209    15189      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as ready for review August 12, 2024 16:30
@zacharyburnett zacharyburnett requested a review from a team as a code owner August 12, 2024 16:30
@zacharyburnett zacharyburnett added this to the Build 11.1 milestone Aug 12, 2024
@braingram
Copy link
Collaborator

Would this allow removing the additions in #8691? If so, I'd say we remove those cibuildwheel changes as the upper pin in this PR is easier to maintain.

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Aug 13, 2024

Would this allow removing the additions in #8691? If so, I'd say we remove those cibuildwheel changes as the upper pin in this PR is easier to maintain.

I assumed so when making this PR, but it doesn't appear to have worked that way for drizzlepac so I'll do some testing on that today EDIT: it does work; cibuildwheel does respect the python-requires pin in the metadata. This means we can remove #8691

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll close #8692 as well.

@zacharyburnett zacharyburnett merged commit 38ea9b7 into spacetelescope:master Aug 14, 2024
29 checks passed
@zacharyburnett zacharyburnett deleted the scsb170 branch August 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools installation no-changelog-entry-needed testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants