remove unsupported end
from ami logs and remove MultilineLogger
#8550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jwst.associations.lib.log_config globally sets the logging class to
MultilineLogger
which can cause seemingly unrelated tests to fail: https://github.com/spacetelescope/stpipe/actions/runs/9445531594/job/26087417184#step:10:189The failure revealed a bug in the ami log messages (
end
is not a supported kwarg for these calls).This PR also removes
MultilineLogger
and the global call tosetLoggerClass
.This class was added in the "inital commit":
5915b0e#diff-9e38d1ac7b11ff469184d069a47776082c49c376e91e3b8dbb9e3b3872a6627bR177
and will change other logging if the association module is imported. For example:
produces:
removing
import jwst.associations.lib.log_config
produces:(note the rather extensive log formatting that stpipe introduces, this is not part of this PR).
With this PR the output (with the
jwst.association.lib.log_config
) is:(and the same if
jwst.associations.lib.log_config
is not imported).Fixes #6407
and is an alternative to #7616
Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1534/
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR