-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3632: Change the Spec of Ramp Fitting to Select Algorithm #8503
Conversation
…fferent ramp fitting algorithm.
…the 'algorithm' argument for ramp fitting to be able to select using the C extension or the python code to run ramp fitting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this require any changes in lower-level functions in order to pass this new param value? Or is it already there, hardwired to the 'OLS' value?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8503 +/- ##
==========================================
+ Coverage 57.93% 57.97% +0.04%
==========================================
Files 387 387
Lines 38839 38830 -9
==========================================
+ Hits 22502 22513 +11
+ Misses 16337 16317 -20 ☔ View full report in Codecov by Sentry. |
I'm not quite sure what you're asking here, but in STCAL the algorithm selection is here: |
OK, I see that so it's all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. And I don't see the need for a regtest run, since this shouldn't have any change on anything.
Resolves JP-3632
Closes #8501
This PR addresses the ability to select the C extension implementation of ramp fitting or the python implementation.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR