Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3632: Change the Spec of Ramp Fitting to Select Algorithm #8503

Merged
merged 3 commits into from
May 23, 2024

Conversation

kmacdonald-stsci
Copy link
Contributor

@kmacdonald-stsci kmacdonald-stsci commented May 23, 2024

Resolves JP-3632

Closes #8501

This PR addresses the ability to select the C extension implementation of ramp fitting or the python implementation.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@kmacdonald-stsci kmacdonald-stsci requested a review from a team as a code owner May 23, 2024 11:55
…the 'algorithm' argument for ramp fitting to be able to select using the C extension or the python code to run ramp fitting.
@hbushouse hbushouse added this to the Build 11.0 milestone May 23, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require any changes in lower-level functions in order to pass this new param value? Or is it already there, hardwired to the 'OLS' value?

docs/jwst/ramp_fitting/arguments.rst Outdated Show resolved Hide resolved
jwst/ramp_fitting/ramp_fit_step.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.97%. Comparing base (781e0e0) to head (f24f296).
Report is 10 commits behind head on master.

Current head f24f296 differs from pull request most recent head 14b4a19

Please upload reports for the commit 14b4a19 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8503      +/-   ##
==========================================
+ Coverage   57.93%   57.97%   +0.04%     
==========================================
  Files         387      387              
  Lines       38839    38830       -9     
==========================================
+ Hits        22502    22513      +11     
+ Misses      16337    16317      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmacdonald-stsci
Copy link
Contributor Author

Does this require any changes in lower-level functions in order to pass this new param value? Or is it already there, hardwired to the 'OLS' value?

I'm not quite sure what you're asking here, but in STCAL the algorithm selection is here:

https://github.com/spacetelescope/stcal/blob/6739c1c6b0559943bd4ac29e90e009541e217f00/src/stcal/ramp_fitting/ramp_fit.py#L175

@hbushouse
Copy link
Collaborator

Does this require any changes in lower-level functions in order to pass this new param value? Or is it already there, hardwired to the 'OLS' value?

I'm not quite sure what you're asking here, but in STCAL the algorithm selection is here:

https://github.com/spacetelescope/stcal/blob/6739c1c6b0559943bd4ac29e90e009541e217f00/src/stcal/ramp_fitting/ramp_fit.py#L175

OK, I see that algorithm is already being passed as an argument to the ramp_fit function here:
https://github.com/spacetelescope/stcal/blob/6739c1c6b0559943bd4ac29e90e009541e217f00/src/stcal/ramp_fitting/ramp_fit.py#L96

so it's all good.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And I don't see the need for a regtest run, since this shouldn't have any change on anything.

@hbushouse hbushouse merged commit 3705c37 into spacetelescope:master May 23, 2024
24 checks passed
@kmacdonald-stsci kmacdonald-stsci deleted the jp_3632 branch July 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add algorithm parameter to ramp_fit spec
2 participants