-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3616: Fix NIRSpec FS spec3 slit name #8470
JP-3616: Fix NIRSpec FS spec3 slit name #8470
Conversation
Regression tests started here: |
Regression tests show expected changes to SLTNAME and extraction parameters for nirspec_fs_spec3. The remaining failures are unrelated. |
72d879b
to
80c1f88
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8470 +/- ##
==========================================
+ Coverage 56.38% 57.96% +1.58%
==========================================
Files 387 387
Lines 38716 38811 +95
==========================================
+ Hits 21830 22498 +668
+ Misses 16886 16313 -573 ☔ View full report in Codecov by Sentry. |
80c1f88
to
7d56e20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look pretty straight forward. Curious, I assume this was just affecting the slit name that's somewhere in the datamodel instance of the output 1-D spectrum (for non-primary slits)? And not actually affecting anything with file naming, etc.?
Correct - the file naming was correct, but the SLTNAME in the output header and slit.name in the model was wrong. The only other effect was that the wrong name was used for retrieving extraction parameters. The differences between default extraction parameters are pretty minor for the fixed slits. |
Resolves JP-3616
Closes #8469
When NIRSpec fixed slit data is extracted as a SlitModel, take the slit name from the name attribute if possible.
Also adding a couple basic unit tests to exercise the extract1d step for NIRSpec FS and MOS modes, including testing the output slit name.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionupdated relevant documentationHow to run regression tests on a PR