Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3616: Fix NIRSpec FS spec3 slit name #8470

Merged
merged 3 commits into from
May 9, 2024

Conversation

melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented May 8, 2024

Resolves JP-3616

Closes #8469

When NIRSpec fixed slit data is extracted as a SlitModel, take the slit name from the name attribute if possible.

Also adding a couple basic unit tests to exercise the extract1d step for NIRSpec FS and MOS modes, including testing the output slit name.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@melanieclarke melanieclarke self-assigned this May 8, 2024
@melanieclarke melanieclarke added this to the Build 11.0 milestone May 8, 2024
@melanieclarke
Copy link
Collaborator Author

@melanieclarke
Copy link
Collaborator Author

Regression tests show expected changes to SLTNAME and extraction parameters for nirspec_fs_spec3. The remaining failures are unrelated.

@melanieclarke melanieclarke marked this pull request as ready for review May 8, 2024 19:00
@melanieclarke melanieclarke requested a review from a team as a code owner May 8, 2024 19:00
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.96%. Comparing base (6580914) to head (7d56e20).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8470      +/-   ##
==========================================
+ Coverage   56.38%   57.96%   +1.58%     
==========================================
  Files         387      387              
  Lines       38716    38811      +95     
==========================================
+ Hits        21830    22498     +668     
+ Misses      16886    16313     -573     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look pretty straight forward. Curious, I assume this was just affecting the slit name that's somewhere in the datamodel instance of the output 1-D spectrum (for non-primary slits)? And not actually affecting anything with file naming, etc.?

@hbushouse hbushouse merged commit b551294 into spacetelescope:master May 9, 2024
27 of 28 checks passed
@melanieclarke
Copy link
Collaborator Author

Updates look pretty straight forward. Curious, I assume this was just affecting the slit name that's somewhere in the datamodel instance of the output 1-D spectrum (for non-primary slits)? And not actually affecting anything with file naming, etc.?

Correct - the file naming was correct, but the SLTNAME in the output header and slit.name in the model was wrong. The only other effect was that the wrong name was used for retrieving extraction parameters. The differences between default extraction parameters are pretty minor for the fixed slits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NIRSpec FS: wrong slit name in spec3
2 participants