Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify checklist in PR template #8466

Merged
merged 4 commits into from
May 8, 2024
Merged

clarify checklist in PR template #8466

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39119ad
clarify checklist in PR template
braingram May 7, 2024
e34cb97
add item to checklist about resolving comments
braingram May 7, 2024
de319ef
reorder checklist add note about irrelevant items
braingram May 7, 2024
2fe1df6
add note about permissions
braingram May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ Closes #
<!-- describe the changes comprising this PR here -->
This PR addresses ...

**Checklist for maintainers**
**Checklist for PR authors (skip items if you don't have permissions or they are not applicable)**
- [ ] added entry in `CHANGES.rst` within the relevant release section
- [ ] updated or added relevant tests
- [ ] updated relevant documentation
- [ ] added relevant milestone
- [ ] added relevant label(s)
- [ ] ran regression tests, post a link to the Jenkins job below.
[How to run regression tests on a PR](https://github.com/spacetelescope/jwst/wiki/Running-Regression-Tests-Against-PR-Branches)
- [ ] All comments are resolved
hbushouse marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Make sure the JIRA ticket is [resolved properly](https://github.com/spacetelescope/jwst/wiki/How-to-resolve-JIRA-issues)
Loading