Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3588: Update extract_1d_step.py to call pastasoss #8397

Closed
wants to merge 8 commits into from

Conversation

hover2pi
Copy link
Contributor

@hover2pi hover2pi commented Mar 29, 2024

JP-3588

This calls the pastasoss module to generate the correct wavemap and spectrace reffiles for the PWCPOS of the given observation.

@hover2pi hover2pi requested a review from a team as a code owner March 29, 2024 20:00
@hover2pi hover2pi changed the title Update extract_1d_step.py to call pastasoss [JP-3588]: Update extract_1d_step.py to call pastasoss Mar 29, 2024
@hover2pi hover2pi changed the title [JP-3588]: Update extract_1d_step.py to call pastasoss JP-3588: Update extract_1d_step.py to call pastasoss Mar 29, 2024
@hover2pi hover2pi marked this pull request as draft March 29, 2024 20:03
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 13.02521% with 207 lines in your changes missing coverage. Please review.

Project coverage is 74.30%. Comparing base (2fb073e) to head (9a116f3).

Files with missing lines Patch % Lines
jwst/extract_1d/soss_extract/soss_wavemaps.py 2.43% 80 Missing ⚠️
jwst/extract_1d/soss_extract/soss_traces.py 10.34% 52 Missing ⚠️
jwst/extract_1d/soss_extract/wavecal.py 30.55% 50 Missing ⚠️
jwst/extract_1d/soss_extract/soss_extract.py 3.84% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8397      +/-   ##
==========================================
- Coverage   75.31%   74.30%   -1.01%     
==========================================
  Files         474      489      +15     
  Lines       38965    46082    +7117     
==========================================
+ Hits        29345    34240    +4895     
- Misses       9620    11842    +2222     
Flag Coverage Δ *Carryforward flag
nightly 77.62% <ø> (+0.28%) ⬆️ Carriedforward from 2fb073e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hover2pi
Copy link
Contributor Author

@tapastro Should this PR be closed if you are making a new one with our combined changes in it? Also, please let me know when you have a working version as the SOSS team needs to do some preliminary testing before we can deliver the new pastasoss reference file. Thanks!

@melanieclarke
Copy link
Collaborator

Closing in favor of #8763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants