don't use crds sync for CRDS caching, and also consolidate CI jobs
#7444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automation
zacharyburnett
commented
Jan 30, 2023
.github/workflows/ci.yml
Outdated
Comment on lines
70
to
85
| - run: > | ||
| echo "pmap=$( | ||
| curl -s -X POST -d '{"jsonrpc": "1.0", "method": "get_default_context", "params": ["jwst"], "id": 1}' ${{ env.CRDS_SERVER_URL }}/json/ | | ||
| python -c "import sys, json; print(json.load(sys.stdin)['result'])" | ||
| )" >> $GITHUB_OUTPUT | ||
| # Get default CRDS_CONTEXT without installing crds client | ||
| # See https://hst-crds.stsci.edu/static/users_guide/web_services.html#generic-request | ||
| id: crds-context | ||
| if: ${{ contains(matrix.toxenv, 'test') && !contains(matrix.toxenv, 'opencv') }} | ||
| - run: echo "CRDS CONTEXT ${{ steps.crds-context.outputs.pmap }}" | ||
| if: ${{ contains(matrix.toxenv, 'test') && !contains(matrix.toxenv, 'opencv') }} | ||
| - uses: actions/cache@v3 | ||
| with: | ||
| path: ${{ env.CRDS_PATH }} | ||
| key: crds-${{ needs.cache_crds.outputs.crds-context }} | ||
| key: crds-${{ steps.crds-context.outputs.pmap }} | ||
| if: ${{ contains(matrix.toxenv, 'test') && !contains(matrix.toxenv, 'opencv') }} |
There was a problem hiding this comment.
only cache CRDS for test job if it does not have the opencv factor
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7444 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 449 449
Lines 36029 36029
=======================================
Hits 27952 27952
Misses 8077 8077
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zacharyburnett
changed the title
crds sync for CRDS cachingcrds sync for CRDS caching and consolidate jobs
zacharyburnett
changed the title
crds sync for CRDS caching and consolidate jobscrds sync for CRDS caching, and also consolidate CI jobs
zacharyburnett
force-pushed
the
cache_crds
branch
from
c928df7 to
d8b42f1
Compare
|
superseded by #7498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue brought up in #7414 (comment), where the CRDS caching is broken due to not caching the correct files. Additionally, consolidates CI jobs to reduce duplicate configuration in
ci.yml. Altogether this should be a simple change to simplify the CI.Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR