BUG: Not all viewers have get_limits

[pllim]

Description

This pull request is to fix broken pan/zoom on Plot Options histogram.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (629fa62) to head (08fde20).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3361   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         125      125           
  Lines       19227    19227           
=======================================
  Hits        17068    17068           
  Misses       2159     2159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rosteen]

The histogram viewer actually does have previous zoom:

And now clicking it gives this error instead:

File [~/projects/jdaviz/jdaviz/core/tools.py:166](http://localhost:8888/lab/tree/testing/~/projects/jdaviz/jdaviz/core/tools.py#line=165), in PrevZoom.activate(self)
    165 def activate(self):
--> 166     if self.viewer._prev_limits is None:
    167         return
    168     prev_limits = self.viewer._prev_limits

AttributeError: 'BqplotHistogramView' object has no attribute '_prev_limits'

[rosteen]

@kecnry thoughts? Probably not particularly needed here, it would be nice to have but maybe if we can't support it here we just remove it.

[kecnry]

Is there another way to get the limits (or implement get_limits)?

[pllim]

I think get_limits is something we invented in Jdaviz. It is not available for a viewer class we used directly from glue-jupyter, e.g., https://github.com/glue-viz/glue-jupyter/blob/main/glue_jupyter/bqplot/histogram/viewer.py

jdaviz/jdaviz/configs/default/plugins/viewers.py

Line 170 in 629fa62

def get_limits(self):

[pllim]

bisect blame the breakage on #3262 (backport of #3249 which is Past Self again) . Pretty sure it broke between v4.0.0 and v4.0.1

[pllim]

Thanks for the review. I basically reverted the offending change that I added in #3249 . Should work now.

[rosteen]

Thanks!