Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model fitting: ensure specutils has access to equivs & set targ solid angle #3343

Merged
merged 5 commits into from
Dec 19, 2024

add indirect conversion handling for PIX2 and test coverage

0a70c5f
Select commit
Loading
Failed to load commit list.
Merged

model fitting: ensure specutils has access to equivs & set targ solid angle #3343

add indirect conversion handling for PIX2 and test coverage
0a70c5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 13, 2024 in 1s

88.78% (-0.03%) compared to 6c946d3

View this Pull Request on Codecov

88.78% (-0.03%) compared to 6c946d3

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (6c946d3) to head (0a70c5f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...igs/default/plugins/model_fitting/model_fitting.py 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3343      +/-   ##
==========================================
- Coverage   88.80%   88.78%   -0.03%     
==========================================
  Files         125      125              
  Lines       19137    19174      +37     
==========================================
+ Hits        16995    17023      +28     
- Misses       2142     2151       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov