-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making docs index match better with github 'About' description #3338
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3338 +/- ##
==========================================
- Coverage 88.81% 88.80% -0.01%
==========================================
Files 125 125
Lines 19041 19132 +91
==========================================
+ Hits 16912 16991 +79
- Misses 2129 2141 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW LGTM TQVM FFTM 😸
I'm only two for four on those abbreviations. 🤷🏻♂️ |
I remember "Feel Free To Merge" but number 3 is escaping me. |
I am ok with changing the "about". How about adding in the docs something like: |
TQVM = thank you very much?? |
"Built for the James Webb Space Telescope" might throw some people off, especially if they don't bother reading the rest of the sentence. |
Description
We just changed the About section of the repo from:
to:
This PR adjusts the main docs page to make it match more closely.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.