-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data-menu: enforce layer order #3289
Conversation
0869b57
to
99dcebb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
=======================================
Coverage 88.80% 88.81%
=======================================
Files 125 125
Lines 19019 19030 +11
=======================================
+ Hits 16890 16901 +11
Misses 2129 2129 ☔ View full report in Codecov by Sentry. |
c975f44
to
bf976c7
Compare
bf976c7
to
fb3a49b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks like code. But do we need PO approval given different people have different preferences of ordering?
This was discussed and planned in advance |
Description
This pull request implements a
sort_by
option on theLayerSelect
component, which defaults to the previous behavior oficon
(order layer was added), but also supportszorder
(shows layers on TOP first). Thezorder
ordering is then used for the legend, data-menu,and plot options tabs.Note that for plot options, it is possible to subscribe to layers from multiple viewers, and they may have different zorder. In this case, the zorders are parsed and sorted based on the first viewer they are found in according to the selected viewers.NOTE: this now defers re-ordering plot options tab since we need to give more thought on how the RGB presets logic should work in this case.
Screen.Recording.2024-11-13.at.12.52.12.PM.mov
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.