Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Python 3.13 support #3210

Merged
merged 2 commits into from
Dec 24, 2024
Merged

TST: Python 3.13 support #3210

merged 2 commits into from
Dec 24, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 1, 2024

Description

This pull request is to add Python 3.13 job. Probably no need for change log unless we need real code changes here.

After merge: Follow up issue to remove -dev tag from Python version spec for 3.13 when stable is available from Actions runner.

Fix #3186

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Oct 1, 2024
@pllim pllim added this to the 4.0 milestone Oct 1, 2024
@pllim
Copy link
Contributor Author

pllim commented Oct 1, 2024

Nope. The stack isn't ready.

@pllim
Copy link
Contributor Author

pllim commented Oct 10, 2024

Looks like bqplot dev cannot build from source in Python 3.13.

On the stable job (where bqplot stable is not giving me a problem), I ran into ipython/ipykernel#1248 (it needs a new release).

@pllim
Copy link
Contributor Author

pllim commented Oct 22, 2024

ipykernel finally has a pre-prelease but it broke solara (and our RC testing workflow):

@pllim
Copy link
Contributor Author

pllim commented Oct 22, 2024

devdeps breakage still held up by unmerged PR:

@pllim
Copy link
Contributor Author

pllim commented Nov 4, 2024

devdeps now encounters the next blocker:

stable job is still waiting for new ipykernel release (anything after 2024-07-01).

@pllim
Copy link
Contributor Author

pllim commented Nov 14, 2024

Situation still the same. Looks like we're in still waters.

@kecnry
Copy link
Member

kecnry commented Dec 19, 2024

are we down to only deprecation warnings now that we can address and/or ignore? 🤞

@pllim
Copy link
Contributor Author

pllim commented Dec 19, 2024

No... We're stuck until ipywidgets ipykernel releases.

@pllim
Copy link
Contributor Author

pllim commented Dec 19, 2024

Well... I guess we could ignore. Do you really need Python 3.13 for AAS?

@pllim
Copy link
Contributor Author

pllim commented Dec 19, 2024

devdeps not gonna happen with Python 3.13 until Maarten/Derek pushes glue-viz/bqplot-image-gl#111 forward

@@ -63,6 +63,13 @@ jobs:
toxenv: py310-test
allow_failure: false

- name: Linux - Python 3.13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is least controversial to just add a new basic job rather than attaching to remote data, Roman, or use a non-Linux env.

@kecnry
Copy link
Member

kecnry commented Dec 19, 2024

nope, no rush afaik, just checked the log from your previous push and thought it was only deprecation warnings, which would be fairly easy to address. If there are other blockers, we can keep waiting/checking, I think.

@pllim
Copy link
Contributor Author

pllim commented Dec 19, 2024

Okay I cleaned up the diff. I will take it out of draft when CI green. Thanks for the ping.

@pllim
Copy link
Contributor Author

pllim commented Dec 19, 2024

devdeps remote data failure is unrelated

@pllim
Copy link
Contributor Author

pllim commented Dec 19, 2024

Python 3.11 remote data failure is also unrelated. Python 3.13 job passed.

@pllim pllim marked this pull request as ready for review December 19, 2024 20:25
@rosteen rosteen modified the milestones: 4.1, 4.2 Dec 23, 2024
Ignore DeprecationWarning from ipykernel.

Add note about devdeps.
@pllim pllim modified the milestone: 4.2 Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (24c4440) to head (17cbfea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3210      +/-   ##
==========================================
- Coverage   88.12%   88.11%   -0.01%     
==========================================
  Files         127      127              
  Lines       19574    19574              
==========================================
- Hits        17249    17248       -1     
- Misses       2325     2326       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit 48be154 into spacetelescope:main Dec 24, 2024
20 of 23 checks passed
@pllim pllim deleted the py313 branch December 24, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.13 support
3 participants