-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Python 3.13 support #3210
TST: Python 3.13 support #3210
Conversation
Nope. The stack isn't ready. |
Looks like bqplot dev cannot build from source in Python 3.13. On the stable job (where bqplot stable is not giving me a problem), I ran into ipython/ipykernel#1248 (it needs a new release). |
ipykernel finally has a pre-prelease but it broke solara (and our RC testing workflow): |
devdeps breakage still held up by unmerged PR: |
devdeps now encounters the next blocker: stable job is still waiting for new ipykernel release (anything after 2024-07-01). |
Situation still the same. Looks like we're in still waters. |
are we down to only deprecation warnings now that we can address and/or ignore? 🤞 |
No... We're stuck until |
Well... I guess we could ignore. Do you really need Python 3.13 for AAS? |
devdeps not gonna happen with Python 3.13 until Maarten/Derek pushes glue-viz/bqplot-image-gl#111 forward |
@@ -63,6 +63,13 @@ jobs: | |||
toxenv: py310-test | |||
allow_failure: false | |||
|
|||
- name: Linux - Python 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is least controversial to just add a new basic job rather than attaching to remote data, Roman, or use a non-Linux env.
nope, no rush afaik, just checked the log from your previous push and thought it was only deprecation warnings, which would be fairly easy to address. If there are other blockers, we can keep waiting/checking, I think. |
Okay I cleaned up the diff. I will take it out of draft when CI green. Thanks for the ping. |
devdeps remote data failure is unrelated |
Python 3.11 remote data failure is also unrelated. Python 3.13 job passed. |
Ignore DeprecationWarning from ipykernel. Add note about devdeps.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
==========================================
- Coverage 88.12% 88.11% -0.01%
==========================================
Files 127 127
Lines 19574 19574
==========================================
- Hits 17249 17248 -1
- Misses 2325 2326 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This pull request is to add Python 3.13 job. Probably no need for change log unless we need real code changes here.
After merge: Follow up issue to remove
-dev
tag from Python version spec for 3.13 when stable is available from Actions runner.Fix #3186
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.