-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use towncrier
to handle change log entries
#3193
use towncrier
to handle change log entries
#3193
Conversation
5fcc084
to
018a642
Compare
7d9b429
to
6d8cbb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3193 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 124 124
Lines 18389 18389
=======================================
Hits 16266 16266
Misses 2123 2123 ☔ View full report in Codecov by Sentry. |
If we are going to revisit this in the future, this PR is almost complete but we have to think about:
|
@kecnry , if we want this after all, should re-open this PR and link it to JIRA? Only 3 more points need to be addressed. Maybe 2 points ticket for us? #3193 (comment) |
Modifying the entry for a fragment with multiple PRs will be a bit clumsy, but the pros may outweigh the cons now that there is at least a way to do that. Let's create the ticket and then we can discuss to see when/if to prioritize? |
Oh, turns out I opened a ticket a long time ago. I un-archived it. 🐱 |
Description
Astropy and ASDF use
towncrier
to build their change log entries from news fragments. Usingtowncrier
to handle changelog entries willCHANGES.rst
in PRsCHANGES.rst
consistent and eliminate duplicate sectionsalso adds change log to docs:
Change log entry
Is a change log entry needed? If yes, write a fragment in
changes/
:echo "changed something" > changes/<module>/<pr#>.<changetype>.rst
orecho "changed something" > changes/<pr#>.<changetype>.rst
(see below for change types).If no, maintainer should add a
no-changelog-entry-needed
label.change log entry types...
changes/<module>/<pr#>.feature.rst
: adds new featurechanges/<module>/<pr#>.apichange.rst
: changes APIchanges/<module>/<pr#>.bugfix.rst
: resolves an issuechanges/<module>/<pr#>.other.rst
: other changes and additionsChecklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.