Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: require unit conversion plugin to remove fallback logic for disp units #3160

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 21, 2024

Description

This pull request removes the fallback code for parsing display units from the data viewers and in doing so effectively requires the unit conversion plugin. We should have a discussion about which plugins are considered "mandatory" and how to document that. For now, this PR is just to test to see if there are any failures in the current configs/code logic.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.0 milestone Aug 21, 2024
@kecnry kecnry force-pushed the require-unit-conversion branch from fa94381 to 5540a6c Compare August 21, 2024 15:44
@kecnry
Copy link
Member Author

kecnry commented Aug 21, 2024

looks like all the failing tests are in Mosviz and Specviz2d (which do not yet have the unit conversion plugin, so is unsurprising). Once #3156 is in, we can bring unit conversion to all configs, and then revisit this 🤞

@kecnry kecnry force-pushed the require-unit-conversion branch from 5540a6c to 8d687f7 Compare August 27, 2024 17:45
@rosteen rosteen modified the milestones: 4.0, 4.1 Oct 17, 2024
@rosteen rosteen modified the milestones: 4.1, 4.2 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants