-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update footprint orientations on viewer rotation #2918
Update footprint orientations on viewer rotation #2918
Conversation
@@ -451,7 +455,7 @@ def overlay_regions(self): | |||
Access the regions objects corresponding to the current settings | |||
""" | |||
|
|||
callable_kwargs = {k: getattr(self, k) | |||
callable_kwargs = {k: float(getattr(self, k)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some cases where the traitlet for PA was being interpreted as a string, which causes problems when a float PA offset is subtracted. Here I ensure we're only giving these properties as floats.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
==========================================
+ Coverage 88.76% 88.77% +0.01%
==========================================
Files 111 111
Lines 17178 17181 +3
==========================================
+ Hits 15248 15253 +5
+ Misses 1930 1928 -2 ☔ View full report in Codecov by Sentry. |
ffb4a45
to
fd3f2da
Compare
Works!! Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the small diff and I had thought a lot about how to write this test, took some time to go through it, fan of the creative logic, and everything looks good to me!
Backport PR #2918: Update footprint orientations on viewer rotation
When the Orientation plugin changes reference data to rotate a viewer, the footprint method that's currently used to update each of the footprints' properties tries to act on the selected overlay only, not all overlays.
This PR makes a separate method that gets triggered by changes in reference data, and explicitly calls the relevant method (
_change_overlay
) on each overlay.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.