-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiselect support for dropdown default #2344
Conversation
17f5705
to
70018a4
Compare
70018a4
to
3adf5d8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2344 +/- ##
==========================================
+ Coverage 90.63% 90.66% +0.02%
==========================================
Files 152 152
Lines 17407 17439 +32
==========================================
+ Hits 15777 15811 +34
+ Misses 1630 1628 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the workflow you described behaves as expected, code looks fine. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* multiselect support for dropdown default * show multiselect dropdown if empty * add test-case for deleting viewer
@meeseeksdev backport to v3.6.x |
…4-on-v3.6.x Backport PR #2344 on branch v3.6.x (multiselect support for dropdown default)
Description
This pull request fixes the defaulting behavior of a plugin select component with multiselect enabled. Previously, even if the previous selection was valid, the current selection would be overwritten. Now, the previous selection is maintained. To reproduce: in imviz, create a second viewer, open plot options, enable multiselect, make a selection for the viewer, create or remove a viewer.
This type of workflow is more evident in #2341, so that should be rebased on top of this.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.