change log

spacetelescope · Nov 20, 2024 · d6e40ba · d6e40ba
1 parent 7f9e561
commit d6e40ba
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -92,6 +92,10 @@ Bug Fixes
 
 - Fixed width of sliders in plugins to use full-width of plugin. [#3303]
 
+- Fixed broken flux unit conversions in all plugins that respond to changes in flux unit changes. These cases
+  occured when certain flux to flux conversions occured, as well as certain conversions between flux and surface
+  brightness. This PR also fixed an issue with unit string formatting in aperture photometry. [#3228]
+
 Cubeviz
 ^^^^^^^
 

diff --git a/jdaviz/core/unit_conversion_utils.py b/jdaviz/core/unit_conversion_utils.py
@@ -257,11 +257,6 @@ def flux_conversion_general(values, original_unit, target_unit,
     directly using Astropy's `unit.to()`, as it handles additional logic for
     special cases.
 
-    Note: that this is a simplified version of `utils.flux_conversion`.
-    Unlike that function, all required equivalencies must be explicitly passed
-    in, instead of being generated from an input Spectrum1D object. This function
-    could replace that one, as a follow up.
-
     Parameters
     ----------
     values : array-like or float