fix support for multiple file/objects across multiple viewers

jdaviz/configs/imviz/plugins/footprints/footprints.py

@@ -411,7 +411,12 @@ def overlay_regions(self):
                            for k in ('ra', 'dec', 'pa', 'v2_offset', 'v3_offset')}
 
         if self.preset_selected == 'From File...':
-            regs = self.preset.selected_obj
+            # we need to cache these locally in order to support multiple files/regions between
+            # different overlay entries all selecting From File...
+            overlay = self._overlays.get(self.overlay_selected, {})
+            if 'regions' not in overlay and isinstance(self.preset.selected_obj, regions.Regions):
+                overlay['regions'] = self.preset.selected_obj
+            regs = overlay.get('regions')
         elif self.preset_selected in preset_regions._instruments:
             regs = preset_regions.jwst_footprint(self.preset_selected, **callable_kwargs)
         else:

jdaviz/core/template_mixin.py

@@ -847,7 +847,7 @@ def _on_file_path_changed(self, event):
 
     def import_file(self, path):
         """
-        Select 'From File...' and set the path
+        Select 'From File...' and set the path.
         """
         # NOTE: this will trigger self._from_file_changed which in turn will
         # pass through the parser, raise an error if necessary, and set
@@ -856,12 +856,13 @@ def import_file(self, path):
 
     def import_obj(self, obj):
         """
+        Import a supported object directly from the API.
         """
         msg, self._cached_obj = self._file_parser(obj)
         if msg:
             raise ValueError(msg)
-        self.selected = 'From File...'
         self.from_file = list(self._cached_obj.keys())[0]
+        self.selected = 'From File...'
 
 
 class HasFileImportSelect(VuetifyTemplate, HubListener):