WIP: HLA-1251: Include "modest" sized sources on the deblend list #1801
Conversation
deblending list as these sources need deblending too. During the update to ease the burden of deblending enormously large sources where the largest sources are ignored, the modest sized sources did not get added to the deblending list as an oversight.
mdlpstsci
changed the title
mdlpstsci
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1801 +/- ##
==========================================
- Coverage 33.32% 31.46% -1.86%
==========================================
Files 126 160 +34
Lines 31201 35173 +3972
Branches 5775 0 -5775
==========================================
+ Hits 10398 11068 +670
- Misses 19641 24105 +4464
+ Partials 1162 0 -1162 ☔ View full report in Codecov by Sentry. |
testing as it can take too much time to execute. Further, the test was designed for generating statistics, after the fact, on the quality of the alignment (via RMS) during the processing.
|
I added a comment on the Jira ticket with a different approach to this problem. I suspect that the |
|
This question is for either of you (@mdlpstsci or @rlwastro) You may have already tested the results of this code change, but if not, can you recommend a good dataset to test this PR with? |
|
@s-goldman @rlwastro I am still working this issue as I am not necessarily in full agreement with Rick's suggestion. I have moved it to lower priority as a Jira ticket. |
mdlpstsci
changed the title
Resolves HLA-1251
Closes #
This PR addresses ...
Added the "modest" sized sources (segments < kernel size) to the
deblending list as these sources need deblending too. During the update to ease the burden of deblending enormously large sources where the largest sources are ignored, the modest sized sources did not get added to the deblending list as an oversight.
Checklist for maintainers
CHANGELOG.rstwithin the relevant release sectionHow to run regression tests on a PR