Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1120: Force a consistent default value for do_verify_guiding #1682

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

mdlpstsci
Copy link
Collaborator

@mdlpstsci mdlpstsci commented Oct 24, 2023

Resolves HLA-1120

Closes # ---

This PR forces a consistent default value for do_verify_guiding() when used on the command line or via the runastrodriz.process() API. The do_verify_guiding() function is currently set to False (or turned off) for normal processing. The alogorithm encapsulated in this function is still being worked and is considered experimental.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

…mand line and via the runastrodriz.process API.
@mdlpstsci mdlpstsci self-assigned this Oct 24, 2023
@mdlpstsci mdlpstsci requested a review from a team as a code owner October 24, 2023 21:14
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
drizzlepac/runastrodriz.py 41.54% <ø> (-0.42%) ⬇️

... and 37 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@mdlpstsci mdlpstsci merged commit c495148 into spacetelescope:master Oct 25, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants