HLA-1111: Updated SVM filenames for WFPC2

[s-goldman]

Resolves HLA-1111

Closes #1662

This PR changes SVM filenames of WFPC2 products. The current SVM filenames follow the following structure:

hst_<propid>_<obsetid>_<instr>_<detector>_<filter>_<ipppss>_dr[cz].fits

where previously the <instr> and <detector> were both WFPC2. With these changes, the <detector> is forced to be "pc" if the <instr> is "WFPC2".

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
drizzlepac/hapsequencer.py	58.13% <ø> (+6.16%)	⬆️
drizzlepac/runastrodriz.py	41.95% <ø> (+6.61%)	⬆️
drizzlepac/align.py	48.69% <0.00%> (-20.66%)	⬇️
drizzlepac/haputils/align_utils.py	81.12% <0.00%> (+4.22%)	⬆️
drizzlepac/haputils/poller_utils.py	52.06% <0.00%> (+3.71%)	⬆️
drizzlepac/haputils/product.py	65.21% <50.00%> (+3.09%)	⬆️
drizzlepac/wfpc2Data.py	10.58% <0.00%> (-24.46%)	⬇️
drizzlepac/haputils/config_utils.py	68.54% <0.00%> (+13.24%)	⬆️

... and 127 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[s-goldman]

I also had to change mentions of wfpc2_wfpc2 in filenames and json files to wfpc2_pc for the code to work properly.

[mdlpstsci]

@s-goldman Can you please check PR#1473 where Warren changed the names to include ...wfpc2_wfpc2... In his case he was eliminating both the use of wf and pc. While I can see there are some unrelated changes his PR, it is good to check this PR to make sure all the necessary changes have been addressed by this PR. For example, the environment variable needed for SVM catalog generation for WFPC2 has not been updated in hapsequencer.py in this PR.

[s-goldman]

@s-goldman Can you please check PR#1473 where Warren changed the names to include ...wfpc2_wfpc2... In his case he was eliminating both the use of wf and pc. While I can see there are some unrelated changes his PR, it is good to check this PR to make sure all the necessary changes have been addressed by this PR. For example, the environment variable needed for SVM catalog generation for WFPC2 has not been updated in hapsequencer.py in this PR.

I've reverted the changes related to WFPC2 from #PR1473 and the code passes the jenkins regression tests.

[mdlpstsci]

Sorry (!) I know this is tedious, but I think we need to keep the nomenclature and file structure consistent across all instruments. It looks like the [svm | mvm]_parameters need to have the subdirectories for WFPC2 renamed to wfpc2/pc/*.json. This will also require changing the contents of the */index files.

[s-goldman]

Sorry (!) I know this is tedious, but I think we need to keep the nomenclature and file structure consistent across all instruments. It looks like the [svm | mvm]_parameters need to have the subdirectories for WFPC2 renamed to wfpc2/pc/*.json. This will also require changing the contents of the */index files.

No worries, I totally agree. Thanks for catching that. I've made the change in the most recent commit.

[mdlpstsci]

The index file contents have to be updated, and then it is ready to go.

[mdlpstsci]

Lots of nooks and crannies for this ticket!