-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use PyPI upload workflow from OpenAstronomy #1677
Merged
zacharyburnett
merged 3 commits into
spacetelescope:master
from
zacharyburnett:ci/openastronomy
Oct 5, 2023
Merged
use PyPI upload workflow from OpenAstronomy #1677
zacharyburnett
merged 3 commits into
spacetelescope:master
from
zacharyburnett:ci/openastronomy
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
force-pushed
the
ci/openastronomy
branch
from
October 2, 2023 14:46
90dc8a8
to
ae3d4d9
Compare
Codecov ReportAll modified lines are covered by tests ✅ see 39 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
mdlpstsci
previously approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zach's baliwick so I believe he is the best authority on this topic!
The |
zacharyburnett
force-pushed
the
ci/openastronomy
branch
from
October 5, 2023 12:47
363b2f9
to
d923c94
Compare
zacharyburnett
commented
Oct 5, 2023
mdlpstsci
approved these changes
Oct 5, 2023
mdlpstsci
pushed a commit
to mdlpstsci/drizzlepac
that referenced
this pull request
Oct 26, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SCSB-108
This PR changes the PyPI upload process to use the OpenAstronomy workflow instead of the STScI one. The workflow in this PR is configured to test the build with each pull request push, and then publish upon an official release.
Checklist for maintainers
added entry inCHANGELOG.rst
within the relevant release sectionupdated or added relevant testsupdated relevant documentationran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR