Unit test added for wcs_functions.py #1654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-goldman
added
enhancement
no-changelog-entry-needed
jirahub-ignore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
- Coverage 33.76% 32.34% -1.42%
==========================================
Files 126 159 +33
Lines 31157 35077 +3920
Branches 5710 0 -5710
==========================================
+ Hits 10520 11347 +827
- Misses 19448 23730 +4282
+ Partials 1189 0 -1189 ☔ View full report in Codecov by Sentry. |
mcara
reviewed
Aug 23, 2023
mcara
reviewed
Aug 23, 2023
mcara
reviewed
Aug 23, 2023
|
@mcara I've added your suggestions as well as a unit test that uses very small fits files, mostly just encapsulating the header information of a sample drc and flc file into fits files. |
mcara
requested changes
Aug 23, 2023
Co-authored-by: Mihai Cara <[email protected]>
Co-authored-by: Mihai Cara <[email protected]>
|
@mcara I like those suggestion far better that what I had. Thanks, suggestions included. |
mcara
previously approved these changes
Aug 24, 2023
nden
reviewed
Dec 7, 2023
nden
reviewed
Dec 7, 2023
nden
reviewed
Dec 14, 2023
s-goldman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unit test has been added to wcs_functions using a sample drc and flc fits header files.