Remove use of astroquery from drizzlepac #1606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlpstsci
added
code cleanup
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1606 +/- ##
==========================================
- Coverage 32.39% 31.34% -1.06%
==========================================
Files 159 156 -3
Lines 35047 34391 -656
Branches 0 5624 +5624
==========================================
- Hits 11355 10779 -576
+ Misses 23692 22524 -1168
- Partials 0 1088 +1088
☔ View full report in Codecov by Sentry. |
mdlpstsci
force-pushed
the
remove_astroquery
branch
from
06691a9 to
841867e
Compare
…hive, and remove the "skip" from the remaining PyTests which "know" the data that needs to be processed. This data had to be loaded onto Artifactory to support the tests.
mdlpstsci
force-pushed
the
remove_astroquery
branch
from
6443574 to
c0f726f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the astroquery package via the drizzlepac astroquery_utils module has been removed. As observed in other spacetelescope packages, a conflict between astroquery and Artifactory caused PyTests to fail in an inexplicable way. The PyTests have been modified to use Artifactory. The few PyTests which deliberately have their datasets defined based on a randomly selected dataset from an input file have been set to skip. These tests were used to derive statistics on the success rate of alignment for single visits, so they really are deprecated pieces of code. Bits of other modules in drizzlepac had to be modified to accommodate the removal of astroquery.
The pyproject.toml file was modified to force an upper limit on the Numpy version until incompatible issues can be resolved.