Fix devdeps, other updates #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
=======================================
Coverage 75.29% 75.29%
=======================================
Files 7 7
Lines 344 344
=======================================
Hits 259 259
Misses 85 85 ☔ View full report in Codecov by Sentry. |
because of pesky test data files
and tell tox where data is
|
Yeah, your manifest prunes out the test data. The build isolation stuff isn't going to work. |
This comment was marked as resolved.
This comment was marked as resolved.
and also I think no xdist is faster
and also maybe tox can try devdeps now
This was referenced Nov 28, 2023
|
Impressive! Many thanks! One favor, please: can you, please move |
|
and I will think about one more request just to get to 20 commits |
|
Maybe @jhunkeler will have ideas if you can get him to review. 😸 |
|
I wished I could steal @jhunkeler brains to review this PR. |
|
Fun fact: The job without tox is 3x faster despite not using xdist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use "Squash and Merge" button if you decide to merge this!
I was trying to fix devdeps and went down the rabbit hole of updating everything else to current standards.
Close #97
Address Windows portion of #62