-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ThorlabsFW102CDll service for controlling Thorlabs FW102C motorized filter wheel #180
base: develop
Are you sure you want to change the base?
Conversation
@a-sevin what I know about dlls in catkit2 is that we keep them off repo. Some other Thorlabs services implement an autodetection of the DLL, I think the picomotors for example (pm). |
For reference, this is the implementation for the 102C in one of our outdated repositories: That's also what I based the Newport filter wheel service in THD2 on. Not sure if this is helpful to you. |
The issue with this implementation is that it is not possible to know which device is connected to it. At best, the type can be identified, but not the serial number. As there are two 102C on the THD bench, this could potentially lead to difficulties at some point. |
e1f2341
to
fd2fa83
Compare
This service uses the Thorlabs FW102C filter wheel SDK v5.0.0.
The Thorlabs FW102C filter wheel SDK is available at https://www.thorlabs.com/software_pages/ViewSoftwarePage.cfm?Code=FW102C.
This version lets you identify the filter wheel by its serial number.
I have a few questions about this version.
os.add_dll_directory
parameter instead of adding the DLL to the repository. What's the good choice ?