Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update STIPS for version 2.0 release #163

Merged
merged 54 commits into from
Sep 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
16c439f
Updated to avoid masked column issues with astropy.
york-stsci Aug 20, 2021
1782bf2
Merge branch 'spacetelescope:master' into master
york-stsci Jul 6, 2022
410b8c4
First working revision of new environment.
york-stsci Jul 6, 2022
ccc15e4
Removed the upper version limit on python
york-stsci Jul 6, 2022
f949a40
removed python 3.10 because conda doesn't like it?
york-stsci Jul 6, 2022
a95e029
Explicitly documented setting the poppy version
york-stsci Jul 7, 2022
4409752
First draft of removing redundant code for version 2
york-stsci Jul 15, 2022
ed295aa
Removed tests for no longer existing functions
york-stsci Jul 15, 2022
c0fba39
tests passing and unsupported instruments removed
york-stsci Jul 20, 2022
8649e48
Next pass on closing out pre-2.0 issues
york-stsci Jul 21, 2022
04f76d6
Finished current cleanup work
york-stsci Jul 22, 2022
6db6ae3
Updated docs (removed JWST/HST references, added known issues, update…
halkowsi Jul 27, 2022
09ff779
Updated installation instructions to use .sh for ref data
halkowsi Jul 27, 2022
ea3d688
Updated docs
halkowsi Jul 27, 2022
9b19dfe
Inclusion of known issues
halkowsi Jul 27, 2022
e034ab4
Added basic tutorial to docs, simplified for faster runtime
halkowsi Jul 27, 2022
755135a
Added directions for assistance with STIPS
halkowsi Jul 27, 2022
3a4d5cc
Removed outdated examples, updated functional example
halkowsi Jul 27, 2022
dc98ed2
Minimal cleanups to match latest
halkowsi Jul 27, 2022
abf0799
Minimal cleanups
halkowsi Jul 27, 2022
dcb1fda
Removed advanced tutorial notebook, modified basic for better runtime
halkowsi Jul 27, 2022
b989a6f
Installation procedure edits
halkowsi Jul 27, 2022
dd6a2db
Merge pull request #4 from halkowsi/master
york-stsci Jul 27, 2022
4820090
Revert changes of astro_image
gmzsebastian Aug 4, 2022
d303e1e
Changes made as per code review
york-stsci Aug 15, 2022
ab0e393
Changed esutil fork
york-stsci Aug 15, 2022
3397fa6
Changed esutil fork
york-stsci Aug 15, 2022
c605014
Workaround for esutil installation only working with pre-compiled bin…
york-stsci Aug 16, 2022
463480f
Updated documentation for esutil bugs
york-stsci Aug 16, 2022
51bd67c
Trying to build docs from this PR
york-stsci Aug 16, 2022
506daba
Trying to build docs from this PR. Second attempt.
york-stsci Aug 16, 2022
9670831
Fixed typos is creating note and code boxes in the documentation
york-stsci Aug 19, 2022
93a1264
Modified wording
gmzsebastian Aug 19, 2022
5ff2986
Removed instances of non-Roman telescopes
gmzsebastian Aug 19, 2022
4465d5c
Apply suggestions from code review
york-stsci Aug 22, 2022
e4888b3
Updated documentation as per Justin Otor's comments
york-stsci Aug 22, 2022
dc9688e
Apply suggestions from code review
york-stsci Aug 23, 2022
4a62bfb
Switched bullet chars; automated numbered lists
ojustino Aug 23, 2022
e1598db
Standardized monospacing in config file docs
ojustino Aug 23, 2022
a88dcf4
Standardized links/rendering in catalogue_format
ojustino Aug 23, 2022
c06abc2
Standardized module rendering in installation.rst
ojustino Aug 23, 2022
b315aec
Made ease-of-rendering edit for Sphinx
ojustino Aug 23, 2022
fac494f
Added leftover suggestion from code review
ojustino Aug 23, 2022
2281dd2
Found another set of bullets to change
ojustino Aug 23, 2022
c5b8dfe
Merge pull request #5 from ojustino/ojo-2.0-doc-edits
york-stsci Aug 23, 2022
329687b
removed notebook text from example code
york-stsci Aug 24, 2022
83b01df
Merge branch 'master' of https://github.com/york-stsci/STScI-STIPS-1
york-stsci Aug 24, 2022
e61bd70
force a docs rebuild
york-stsci Aug 25, 2022
9afe4fd
Made a minimum-delta change
york-stsci Aug 25, 2022
f1f935f
force a docs rebuild
york-stsci Aug 25, 2022
dd391c1
Made documentation changes as per Jonathan's requests
york-stsci Sep 1, 2022
6b0ec6c
Apply suggestions from code review
york-stsci Sep 2, 2022
86ff3d0
pep8
york-stsci Sep 9, 2022
063858e
Merge branch 'master' of https://github.com/york-stsci/STScI-STIPS-1
york-stsci Sep 9, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 4 additions & 32 deletions .github/workflows/ci_workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@ jobs:
matrix:
include:

# - name: Python 2.7
# os: ubuntu-latest
# python: 2.7

- name: Python 3.7
os: ubuntu-latest
python: 3.7

- name: Python 3.8
os: ubuntu-latest
python: 3.8
Expand All @@ -30,13 +22,13 @@ jobs:
os: ubuntu-latest
python: 3.9

- name: Python 3.8 Mac
- name: Python 3.9 Mac
os: macos-latest
python: 3.8
python: 3.9

- name: Python Long
os: ubuntu-latest
python: 3.8
python: 3.9

steps:
- name: Checkout code
Expand All @@ -50,26 +42,6 @@ jobs:
environment-file: environment.yml
python-version: ${{ matrix.python }}
auto-activate-base: false
# - name: Install Required Data
# shell: bash -l {0}
# run: |
# export TEST_DATA=${HOME}/test_data
# mkdir -p ${TEST_DATA}
# wget https://stsci.box.com/shared/static/4nebx2ndxr7c77lgocfbvxo7c2hyd3in.tgz -O ${TEST_DATA}/stips_data_current.tar.gz
# tar -xzvf ${TEST_DATA}/stips_data_current.tar.gz -C ${TEST_DATA}
# mkdir -p ${TEST_DATA}/synphot
# wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot1.tar.gz -O ${TEST_DATA}/synphot1.tar.gz
# tar -xzvf ${TEST_DATA}/synphot1.tar.gz -C ${TEST_DATA}/synphot/
# wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot2.tar.gz -O ${TEST_DATA}/synphot2.tar.gz
# tar -xzvf ${TEST_DATA}/synphot2.tar.gz -C ${TEST_DATA}/synphot/
# wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot5.tar.gz -O ${TEST_DATA}/synphot5.tar.gz
# tar -xzvf ${TEST_DATA}/synphot5.tar.gz -C ${TEST_DATA}/synphot/
# wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot6.tar.gz -O ${TEST_DATA}/synphot6.tar.gz
# tar -xzvf ${TEST_DATA}/synphot6.tar.gz -C ${TEST_DATA}/synphot/
# wget -qO- https://stsci.box.com/shared/static/7voehzi5krrpml5wgyg8bo954ew7arh2.gz -O ${TEST_DATA}/pandeia_data-1.5.2rc2_roman.gz
# tar -xzvf ${TEST_DATA}/pandeia_data-1.5.2rc2_roman.gz -C ${TEST_DATA}
# wget -qO- https://stsci.box.com/shared/static/qcptcokkbx7fgi3c00w2732yezkxzb99.gz -O ${TEST_DATA}/webbpsf_data.gz
# tar -xzvf ${TEST_DATA}/webbpsf_data.gz -C ${TEST_DATA}
- name: Test with tox
shell: bash -l {0}
if: ${{ matrix.name != 'Python Long' }}
Expand All @@ -94,7 +66,7 @@ jobs:
with:
activate-environment: stips
environment-file: environment.yml
python-version: 3.7
python-version: 3.9
auto-activate-base: false
- name: Build Docs
shell: bash -l {0}
Expand Down
14 changes: 13 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,19 @@ Release Notes
#############

Version History and Change Log
-------------------------------
------------------------------

Version 2.0.0
=============

- STIPS now uses an ePSF, and calculates source appearance on a per-source basis
- Dropped support for python 2, and python <= 3.7
- Dropped support for HST and JWST instruments
- Dropped support for jbt background tool, as its results are JWST-specific
- Updated pandeia to 1.7
- Updated webbpsf to 1.0.0
- Dropped astropy helpers code


Version 1.0.8
=============
Expand Down
106 changes: 6 additions & 100 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,20 +1,13 @@
FROM continuumio/miniconda3
MAINTAINER Space Telescope Science Institute <[email protected]>

# RUN "sh" "-c" "echo nameserver 8.8.8.8 >> /etc/resolv.conf"
# RUN "sh" "-c" "echo forcing APT update"


#########
# Setup #
#########

ENV HOME /root
WORKDIR $HOME

# Place to store data and source
RUN mkdir -p /opt

# Clone STScI-STIPS
RUN git clone https://github.com/spacetelescope/STScI-STIPS.git
ENV STIPSDIR $HOME/STScI-STIPS
Expand All @@ -23,104 +16,17 @@ ENV STIPSDIR $HOME/STScI-STIPS
# Basic apt Requirements #
##########################

WORKDIR $HOME

RUN apt-get update
RUN apt-get install -y python3.7
RUN apt-get install -y python-pip
RUN apt-get install -y wget

# matplotlib requirement
RUN apt-get install -y pkg-config
RUN apt-get install -y libfreetype6-dev
RUN apt-get install -y rsync
RUN apt-get install -y git

# SciPy
RUN apt-get install -y libblas-dev
RUN apt-get install -y liblapack-dev
RUN apt-get install -y gfortran

# Update pip
RUN pip install -U pip
RUN pip install -U setuptools
WORKDIR $STIPSDIR

RUN conda env create -f environment.yml
RUN echo "conda activate stips" >> ~/.bashrc
SHELL ["/bin/bash", "--login", "-c"]

##################
# Reference Data #
##################

# Install reference data under /opt

WORKDIR /opt

# Extract STIPS reference data
RUN wget -qO- https://stsci.box.com/shared/static/4nebx2ndxr7c77lgocfbvxo7c2hyd3in.tgz | tar xvz
ENV stips_data /opt/stips_data

# Extract PySynphot reference data
RUN wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot1.tar.gz | tar xvz
RUN wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot2.tar.gz | tar xvz
RUN wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot5.tar.gz | tar xvz
RUN wget -qO- https://ssb.stsci.edu/trds/tarfiles/synphot6.tar.gz | tar xvz
ENV PYSYN_CDBS /opt/grp/hst/cdbs

# Extract Pandeia reference data
RUN wget -qO- https://stsci.box.com/shared/static/7voehzi5krrpml5wgyg8bo954ew7arh2.gz | tar -xvz
ENV pandeia_refdata /opt/pandeia_data-1.5.2rc2_roman

# Extract WebbPSF reference data
# (note: version number env vars are declared close to where they are used
# to prevent unnecessary rebuilds of the Docker image)
ENV WEBBPSF_DATA_VERSION 0.9.0
RUN wget -qO- https://stsci.box.com/shared/static/qcptcokkbx7fgi3c00w2732yezkxzb99.gz | tar xvz
ENV WEBBPSF_PATH /opt/webbpsf-data

# Prepare environment variables
ENV PYHOME /opt/conda
ENV PYTHON_VERSION 3.7
ENV PATH $HOME/bin:$PATH
ENV LD_LIBRARY_PATH $HOME/lib:$LD_LIBRARY_PATH


########################################
# Setup Conda and Install Requirements #
########################################

WORKDIR $HOME

#RUN conda env update --file $STIPSDIR/environment.yml
RUN conda env create -f $STIPSDIR/environment.yml
ENV PATH /opt/conda/envs/stips/bin:$PATH
RUN echo "conda activate stips" >> /root/.bashrc
ENV CONDA_DEFAULT_ENV stips

# Prepare environment variables
ENV WEBBPSF_SKIP_CHECK 1


##############################
# Install Other Requirements #
##############################

WORKDIR $HOME

# Montage
WORKDIR /opt
RUN git clone https://github.com/Caltech-IPAC/Montage.git
# ADD initdistdata.c ./Montage/lib/src/two_plane_v1.1/initdistdata.c
WORKDIR /opt/Montage
RUN make
RUN pip install montage-wrapper
ENV PATH /opt/Montage/bin:$PATH
WORKDIR $HOME


#################
# Install STIPS #
#################

WORKDIR $STIPSDIR
RUN python setup.py develop

WORKDIR $HOME
RUN echo -e "import stips\nstips.DownloadReferenceData()" >> activate_stips.py
RUN python activate_stips.py
Loading