Generation of genesis keypairs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some typos Create dot dir if it doesn't already exist Add gitignore
Allow only `wallet' subcommand for now. Fix a typo.
Copy over some speculos test boilerplate from go-ledger-sdk Begin adding HW-related commands
Allow user to enter a mnemonic or else create a new one. Don't overwrite existing wallet files.
Making compatible with SMIP-17 and the wallet file format used by smapp
Expected keys have changed since we're now (correctly) including the salt in the master key derivation
Don't use master key as address Use core ed25519 library where possible, but continue using spacemesh version for child key derivation Update tests again to match expected keys
Save the master key in the Wallet (but don't persist it)
Merged
This reverts commit 0f64355. Moved HW wallet support to another branch/PR
Increased Pbkdf2Iterations per OWASP recommendations Refactoring of wallet key/store data structures Use same salt for PBKDF2 and AES
Make salt deterministic Expand tests
Refactor wallet command code
Correctly set default path Bugfix in path to string
Closed
Fix wallet test
Closed
Reset to higher iterations for PBKDF2 WIP: getting MAC error when trying to read file with lower iterations
Remove or comment-out mnemonic-related code Generate wallets using simple random seeds
Remove references to mnemonic, for now
fasmat
reviewed
Mar 30, 2023
Also minor fix to test
Better error handling
Thanks mafa! Better error handling, better handling of JSON marshal/unmarshal
fasmat
reviewed
Mar 31, 2023
fasmat
approved these changes
Mar 31, 2023
fasmat
reviewed
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Closes #17
Closes #16
Closes #15
Closes #14
Closes #13
Closes #12
Allow generation of wallet files in the correct format (as expected by smapp). Harmonize encryption and wallet data structure/file format. Allow reading of wallet files.
TODO: HDPaths are slightly different between smapp and smcli, fix this.HD derivation has been removed for now. It'll be re-added when we finalize the spec.