Add proof deadline to /Submit GRPC #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
force-pushed
the
351-avoid-registration-slip
branch
from
b31772b
to
a26b86d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #410 +/- ##
=========================================
+ Coverage 74.9% 75.1% +0.2%
=========================================
Files 23 23
Lines 1892 1909 +17
=========================================
+ Hits 1418 1435 +17
Misses 357 357
Partials 117 117
|
fasmat
approved these changes
Sep 28, 2023
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 4, 2023
## Motivation Avoid slipping into the next poet round when submitting a challenge late. It's a prerequisite to support phased poets. It will let the nodes avoid wrongly registering in poets with earlier phases (their round has already started). Depends on spacemeshos/poet#410 ## Changes Pass the required time (deadline) by which the poet proof must be ready. If poet decides that the current open round ends after that time - it will reject challenge registration. ## Test Plan - existing tests should pass - added poet client unit test to see if the error is properly detected and handled - the functionality itself is tested in poet tests
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 5, 2023
## Motivation Avoid slipping into the next poet round when submitting a challenge late. It's a prerequisite to support phased poets. It will let the nodes avoid wrongly registering in poets with earlier phases (their round has already started). Depends on spacemeshos/poet#410 ## Changes Pass the required time (deadline) by which the poet proof must be ready. If poet decides that the current open round ends after that time - it will reject challenge registration. ## Test Plan - existing tests should pass - added poet client unit test to see if the error is properly detected and handled - the functionality itself is tested in poet tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #351
Added a new field
deadlinein the/SubmitGRPC method. It allows the node to tell when they need the proof. If the field is provided, the poet will check if the round ends within the requested time and it will reject the registration withFailed Preconditionstatus otherwise. If the field is empty, the check is disabled (it works as before).