Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot not working #394

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix dependabot not working #394

merged 2 commits into from
Sep 19, 2023

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Sep 18, 2023

Dependabot is currently not working for spacemeshos/poet. To verify run:

go install github.com/dependabot/cli/cmd/dependabot@latest
dependabot update go_modules spacemeshos/poet

It will fail with the error:

updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | +-------------------------------+
updater | |            Errors             |
updater | +-------------------------------+
updater | | dependency_file_not_parseable |
updater | +-------------------------------+

The proposed change fixes that by adding a patch version to go.mod and updating ci.yml to still use the newest 1.21.x when building the source code.

@fasmat fasmat requested a review from poszu September 18, 2023 08:45
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #394 (a97c339) into develop (fb07952) will decrease coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop    #394     +/-   ##
=========================================
- Coverage     74.8%   74.7%   -0.2%     
=========================================
  Files           23      23             
  Lines         1898    1898             
=========================================
- Hits          1421    1418      -3     
- Misses         359     361      +2     
- Partials       118     119      +1     

see 1 file with indirect coverage changes

go.mod Outdated Show resolved Hide resolved
@fasmat fasmat added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit 588efe4 Sep 19, 2023
11 checks passed
@fasmat fasmat deleted the fix-dependabot branch September 19, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants