Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up #393

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Cleaning up #393

merged 1 commit into from
Sep 15, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 14, 2023

Cleaning up some redundant code, small refactors to simplify the code etc.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #393 (4f52812) into develop (6a2fb59) will increase coverage by 0.8%.
The diff coverage is 85.3%.

@@            Coverage Diff            @@
##           develop    #393     +/-   ##
=========================================
+ Coverage     73.9%   74.7%   +0.8%     
=========================================
  Files           23      23             
  Lines         1962    1898     -64     
=========================================
- Hits          1450    1418     -32     
+ Misses         386     361     -25     
+ Partials       126     119      -7     
Files Changed Coverage Δ
verifier/verifier.go 80.5% <61.5%> (-13.0%) ⬇️
prover/layer_factory.go 70.0% <70.0%> (ø)
service/service.go 80.3% <85.7%> (+2.0%) ⬆️
server/server.go 79.0% <90.9%> (-0.7%) ⬇️
prover/prover.go 62.8% <96.5%> (+1.9%) ⬆️
server/config.go 77.7% <100.0%> (+10.1%) ⬆️

... and 1 file with indirect coverage changes

@poszu poszu marked this pull request as ready for review September 15, 2023 10:04
@poszu poszu requested a review from fasmat September 15, 2023 10:04
@poszu poszu added this pull request to the merge queue Sep 15, 2023
Merged via the queue into develop with commit fb07952 Sep 15, 2023
11 checks passed
@fasmat fasmat deleted the cleanups branch September 15, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants