Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Go 1.21 #392

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Bump to Go 1.21 #392

merged 1 commit into from
Sep 15, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 14, 2023

Closes #363

Bumped the minimum Go version to 1.21.

🚀 Benchmarks show ~0.7% improvement in PoSW speed

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #392 (79af945) into develop (4ab25f7) will decrease coverage by 0.2%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop    #392     +/-   ##
=========================================
- Coverage     73.9%   73.7%   -0.2%     
=========================================
  Files           23      23             
  Lines         1962    1962             
=========================================
- Hits          1450    1447      -3     
- Misses         386     388      +2     
- Partials       126     127      +1     
Files Changed Coverage Δ
registration/round.go 92.2% <100.0%> (-2.2%) ⬇️
verifier/verifier.go 93.4% <100.0%> (ø)

verifier/verifier.go Show resolved Hide resolved
@poszu poszu added this pull request to the merge queue Sep 15, 2023
Merged via the queue into develop with commit 6a2fb59 Sep 15, 2023
11 checks passed
@fasmat
Copy link
Member

fasmat commented Sep 15, 2023

For dependabot to work with go 1.21 you have to specify a minor version in the go.mod file. See also spacemeshos/go-spacemesh#5016

@fasmat fasmat deleted the bump-go-1.21 branch September 15, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to Go 1.21
2 participants