Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard and remove legacy open rounds recovered by Service #390

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 13, 2023

Fixes a problem with poet version bump.

Previously, the datadir contained both the round in-progress (E) and the open round (E+1). The new Service implemented in #365 doesn't keep open round anymore (it's handled by Registration). When bumping to v0.9.2, the Service will be confused if it finds an open round and will overwrite the round in progress. This PR mitigates it by removing the legacy open round.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #390 (f59d0e4) into develop (00a5521) will increase coverage by 0.2%.
The diff coverage is 61.5%.

@@            Coverage Diff            @@
##           develop    #390     +/-   ##
=========================================
+ Coverage     73.6%   73.9%   +0.2%     
=========================================
  Files           23      23             
  Lines         1954    1962      +8     
=========================================
+ Hits          1439    1450     +11     
+ Misses         388     386      -2     
+ Partials       127     126      -1     
Files Changed Coverage Δ
service/round.go 84.8% <44.4%> (-0.4%) ⬇️
service/service.go 78.3% <100.0%> (+2.6%) ⬆️

@poszu poszu force-pushed the disregard-legacy-open-rounds-in-service branch from b3b9130 to f59d0e4 Compare September 13, 2023 07:03
@poszu poszu marked this pull request as ready for review September 13, 2023 07:04
@poszu poszu requested a review from fasmat September 13, 2023 07:04
@poszu poszu self-assigned this Sep 13, 2023
@poszu poszu requested a review from dshulyak September 13, 2023 07:11
@poszu poszu added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit 4ab25f7 Sep 13, 2023
10 of 11 checks passed
@fasmat fasmat deleted the disregard-legacy-open-rounds-in-service branch September 15, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants