-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register challenges in batches #358
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #358 +/- ##
=========================================
+ Coverage 71.7% 73.6% +1.9%
=========================================
Files 20 20
Lines 1749 1859 +110
=========================================
+ Hits 1255 1370 +115
+ Misses 366 363 -3
+ Partials 128 126 -2
|
service/round.go
Outdated
Subsystem: "round", | ||
Name: "batch_write_latency_seconds", | ||
Help: "Latency of batch write operations", | ||
Buckets: prometheus.ExponentialBuckets(0.0001, 1.5, 20), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it can start at 10ms (0.01s). otherwise there will be a lot of wasted metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 10ms is a little high as I observe latencies < 10ms. Changed min to 1ms.
Closes #357
The submitted challenges are collected in a batch that is written to disk (with sync):
Comparison of
TestLoadSubmits
before and after on an NVME drive with default settings:vs