Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs and round members metric #338

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Aug 7, 2023

Closes #336

  • added some logs, especially log the number of round members when it's recovered and started
  • refactored existing logs
  • improved logging around context cancellation (i.e. previously it incorrectly logged round failure when service was stopped)
  • added metric showing the number of members
  • refactored leaves counter metric
    # HELP poet_round_leaves_total Number of generated leaves in a round
    # TYPE poet_round_leaves_total counter
    poet_round_leaves_total{ID="2"} 1.478935e+06
    poet_round_leaves_total{ID="3"} 0
    # HELP poet_round_members_total Number of members in a round
    # TYPE poet_round_members_total counter
    poet_round_members_total{ID="2"} 0
    poet_round_members_total{ID="3"} 1
    

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #338 (89ee249) into develop (e90b082) will increase coverage by 0.1%.
Report is 2 commits behind head on develop.
The diff coverage is 73.1%.

@@            Coverage Diff            @@
##           develop    #338     +/-   ##
=========================================
+ Coverage     73.0%   73.1%   +0.1%     
=========================================
  Files           17      17             
  Lines         1497    1561     +64     
=========================================
+ Hits          1093    1142     +49     
- Misses         298     315     +17     
+ Partials       106     104      -2     
Files Changed Coverage Δ
server/server.go 74.0% <33.3%> (-0.6%) ⬇️
service/service.go 76.2% <44.6%> (-2.7%) ⬇️
service/round.go 78.8% <92.6%> (+5.6%) ⬆️
prover/prover.go 59.5% <100.0%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

@poszu poszu requested review from dshulyak and fasmat August 7, 2023 15:33
service/round.go Outdated Show resolved Hide resolved
@poszu poszu marked this pull request as ready for review August 8, 2023 08:43
@poszu poszu requested a review from dshulyak August 8, 2023 09:25
service/round.go Outdated Show resolved Hide resolved
@poszu poszu requested a review from dshulyak August 8, 2023 12:56
service/round.go Outdated Show resolved Hide resolved
service/round.go Outdated Show resolved Hide resolved
@poszu poszu added this pull request to the merge queue Aug 8, 2023
Merged via the queue into develop with commit beb3bdf Aug 8, 2023
11 checks passed
@fasmat fasmat deleted the improve-observability branch September 15, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve observability around challenge registration
3 participants