Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uses of require.Assertions in subtests #335

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix uses of require.Assertions in subtests #335

merged 1 commit into from
Aug 4, 2023

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Aug 4, 2023

Closes #334

@poszu poszu requested a review from fasmat August 4, 2023 12:42
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #335 (db4f582) into develop (d159127) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #335   +/-   ##
=======================================
  Coverage     73.2%   73.2%           
=======================================
  Files           17      17           
  Lines         1497    1497           
=======================================
  Hits          1096    1096           
  Misses         296     296           
  Partials       105     105

@poszu poszu added this pull request to the merge queue Aug 4, 2023
Merged via the queue into develop with commit e90b082 Aug 4, 2023
11 checks passed
@fasmat fasmat deleted the 334-fix-require-uses branch September 15, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper use of require in sub-unittests
2 participants
@poszu @fasmat