Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[athena poc] support deploying templates #6513

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Dec 4, 2024

Added support for deploying transactions. The singlesig wallet contract account can deploy a new contract and the principal pays the fee.

💡 It's impossible to spawn the new contract because the transaction doesn't have a template address. A follow-up PR will add support for spawning (and calling) deployed contracts.
ℹ️ this change is compatible with the existing devnet-athena-10

vm/sdk/wallet/tx.go Show resolved Hide resolved
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 77.19298% with 26 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (9b4c234) to head (b457104).
Report is 2 commits behind head on athena-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sql/accounts/accounts.go 62.5% 3 Missing and 6 partials ⚠️
vm/sdk/wallet/tx.go 70.0% 6 Missing and 3 partials ⚠️
vm/core/context.go 85.7% 2 Missing and 1 partial ⚠️
vm/vm.go 50.0% 2 Missing and 1 partial ⚠️
vm/templates/wallet/methods.go 81.8% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           athena-poc   #6513     +/-   ##
============================================
- Coverage        79.5%   79.5%   -0.1%     
============================================
  Files             370     370             
  Lines           47971   48066     +95     
============================================
+ Hits            38180   38252     +72     
- Misses           7591    7600      +9     
- Partials         2200    2214     +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu merged commit c746e4d into athena-poc Dec 4, 2024
12 of 13 checks passed
@poszu poszu deleted the athena-deploying-templates branch December 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants